Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cellHandle instead of index when talking to output webview #14649

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

dhuebner
Copy link
Member

What it does

Now using cellHandle instead of index when "talking" to the output webview. The reason is that in some cases (cell deletion) there is no way to identify a visible cell to the corresponding start index as the notebook no longer contain this cell.

Doing so, we also align cellsSpliced to existing cellMoved webview communication channel, that already uses handles instead of ids.

How to test

Open a notebook with many cells that has output. Delete some cell in the middle. Check that there are any old/overlapping outputs.

Follow-ups

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Review checklist

Reminder for reviewers

@dhuebner
Copy link
Member Author

@JonasHelming
How to create a next release from this PR? This is an important fix...

@dhuebner dhuebner requested a review from msujew December 19, 2024 08:54
@jonah-iden
Copy link
Contributor

@dhuebner for a next release you just go to actions in this tab. Select the publish next release action and then run the run workflow button. There you can select this branch.
It could be that it goes red but still publishes all important packages

Copy link
Contributor

@jbicker jbicker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dhuebner dhuebner merged commit 8d7fa9e into master Dec 19, 2024
11 checks passed
@dhuebner dhuebner deleted the dhuebner/notebook-cellHandle branch December 19, 2024 09:24
@github-actions github-actions bot added this to the 1.58.0 milestone Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants