Allow to auto-start MCP servers on frontend start-up #14736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed #14692 Signed-off-by: Jonas Helming <[email protected]>
JonasHelming
force-pushed
the
GH-14692
branch
from
7440e30 to
c1e8b30
Compare
sdirix
reviewed
Jan 17, 2025
packages/ai-mcp/src/browser/mcp-frontend-application-contribution.ts
Outdated
Show resolved
Hide resolved
packages/ai-mcp/src/browser/mcp-frontend-application-contribution.ts
Outdated
Show resolved
Hide resolved
| this.prevServers = this.convertToMap(servers); | ||
| this.syncServers(this.prevServers); | ||
| this.autoStartServers(this.prevServers); |
There was a problem hiding this comment.
Some usability questions:
- This will only auto start servers when the frontend is started. Should we also auto start servers which are added to the preferences with
autostart: trueor when theirautostartvalue is added or changed? - If a frontend is started with a server set to
autostart: false(or non existing), should we then stop the server in case it is already running?
There was a problem hiding this comment.
1.: I decided to not start them on preference change (this is documented in the settings). Reasoning was that if you start a server manually, you get the message with the functions. If you set up a new server, you probably want to start it manually once. If you have a strong feeling to change this behavior, its fine, but I found it a bit more logical this way.
2.: I decided no, because this would break other frontends that still use this server. Also, "removing auto start", does not imply "stop it" to me. You can still manually stop them, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #14692
What it does
Introduce a new optional property "autostart" for MCP servers to start them automatically when a frontend is started.
How to test
Breaking changes
Attribution
Review checklist
Reminder for reviewers