Update monaco-editor-core to 1.96.3 #14737
Conversation
Fixes eclipse-theia#14726 Contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <[email protected]>
|
Converting to "draft" status while waiting for https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/18700 |
Signed-off-by: Thomas Mäder <[email protected]>
Signed-off-by: Thomas Mäder <[email protected]>
Signed-off-by: Thomas Mäder <[email protected]>
Signed-off-by: Thomas Mäder <[email protected]>
|
https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/18700 has been approved. |
|
@tsmaeder I can take a look today in the evening |
There was a problem hiding this comment.
I performed the following tests:
- QuickPick
- Open
- Select
- Escape
- Text Editor
- Open without extensions (i.e. no syntax highlighting etc.)
- With extensions
- Extract to second window
- Switching theme
- Debugging
- Text Editor Typescript
- Syntax Highlighting
- Error/Warning markers
- Refactor Actions
- Hover
- Autocomplete
- Inline suggestions (AI)
- Drag&Drop of code
- Preferences Editor
- Editing preferences
- JSON view
- Both at same time
- Output channel
- Diff editor
- Open a diff
- Accepting/Reverting a change
- Debug
- Setting, Editing and Hitting break points
I tested both in Browser and Electron
The only behavior finding which I found when testing the apps:
Revert popup
In the diff editor, the reverting a change popup looks broken:
In the current master it looks fine:
examples/browser/webpack.config.js
Outdated
There was a problem hiding this comment.
These changes should be reverted, right?
examples/electron/webpack.config.js
Outdated
| const webpack = require('webpack'); | ||
| const configs = require('./gen-webpack.config.js'); | ||
| const nodeConfig = require('./gen-webpack.node.config.js'); | ||
|
|
||
| const { MonacoWebpackPlugin } = require('@theia/native-webpack-plugin/lib/monaco-webpack-plugins.js'); | ||
|
|
| const iconClasses = this.labelProvider.getIcon(languageUri).split(' '); | ||
| if (iconClasses.length > 0) { | ||
| iconClasses.push('file-icon'); | ||
| } |
There was a problem hiding this comment.
Is this behavior change on purpose? An empty string will now produce file-icon while before it did not.
There was a problem hiding this comment.
I don't think that is correct: an empty string will split to an emtpy array, which has length 0, righ?
There was a problem hiding this comment.
The split() method of
Stringvalues takes a pattern and divides this string into an ordered list of substrings by searching for the pattern, puts these substrings into an array, and returns the array. MDN
The empty string "" therefore only returns a single substring entry, which is the empty string again [""].
That's the same logic as splitting "a", which will also result in ["a"]
For good measure:
| const icon = this.labelProvider.getIcon(uri).split(' '); | ||
| if (icon.length > 0) { | ||
| icon.push('file-icon'); | ||
| } | ||
| return icon; |
There was a problem hiding this comment.
Is this behavior change on purpose? An empty string will now produce file-icon while before it did not.
.vscode/launch.json
Outdated
Signed-off-by: Thomas Mäder <[email protected]>
Signed-off-by: Thomas Mäder <[email protected]>
What it does
Fixes #14726
Contributed on behalf of STMicroelectronics
How to test
This needs a general test of functionality in particular of all editor functionality (including in secondary windows) and all quick-input related functions.
Follow-ups
Breaking changes
Attribution
Review checklist
Reminder for reviewers