Builtins v1.64.2 #106
Merged
Builtins v1.64.2 #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…versions Like so: "preview": false Signed-off-by: Marc Dumais <[email protected]>
alvsan09
reviewed
Dec 16, 2022
src/create-extension-pack.js
Outdated
| @@ -51,7 +51,7 @@ const repository = 'https://github.com/eclipse-theia/vscode-builtin-extensions'; | |||
| * fetched by vscode at build time. | |||
| * https://github.com/microsoft/vscode/blob/1.57.0/product.json#L34-L126 | |||
There was a problem hiding this comment.
The reference needs to be updated to 1.64.2
There was a problem hiding this comment.
Done. I replace the URL with a URI that points to the version of product.json that's checked-out locally.
marcdumais-work
force-pushed
the
1.64.2
branch
from
5f0c0f0
to
fccfdda
Compare
Signed-off-by: Marc Dumais <[email protected]> ran yarn upgrade, to update the repo's dependencies Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work
force-pushed
the
1.64.2
branch
from
fccfdda
to
cbe803e
Compare
alvsan09
approved these changes
Dec 16, 2022
|
Proceeding with release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation of publishing the vscode builtin extensions for 1.64.2. Also include a partial fix for #105
The extensions build locally without issues and seem to work well.