Deprecate SelfSignedCertificate and update accordingly #5727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vietj
force-pushed
the
deprecate-self-signed-certificate
branch
from
dd16e1f to
5b6ce39
Compare
Motivation: SelfSignedCertificate does not work consistently on stock Java distribution and requires Bouncy Castle. As consequence it cannot really be used for testing and is complicated to test as well. Changes: - Deprecate SelfSignedCertificate - Replace usage of SelfSignedCertificate in testing - Remove SelfSignedCertificate from documentation
vietj
force-pushed
the
deprecate-self-signed-certificate
branch
from
5b6ce39 to
06feaf6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
SelfSignedCertificatedoes not work consistently on stock Java distribution and requires Bouncy Castle. As consequence it cannot really be used for testing and is complicated to test as well.Changes:
SelfSignedCertificateSelfSignedCertificatein testingSelfSignedCertificatefrom documentation