Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISV catalog refresh must bring control back to previously selected service. #289

Conversation

Alice1319
Copy link
Contributor

Copy link
Contributor

@swaroopar swaroopar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Alice1319 This solution looks too complex.
Can you please use the URL to store the state? This will make the whole solution more straightforward and neat. This will allow users to share the URL if they want to point to specific service.

@Alice1319 Alice1319 force-pushed the feature/ISV_catalog_refresh_must_bring_control_back branch from 0629e74 to ee8dcab Compare December 6, 2023 09:52
@Alice1319 Alice1319 force-pushed the feature/ISV_catalog_refresh_must_bring_control_back branch 2 times, most recently from 9696aea to b9e5902 Compare December 11, 2023 11:21
@Alice1319 Alice1319 force-pushed the feature/ISV_catalog_refresh_must_bring_control_back branch from b9e5902 to 25a2a24 Compare December 12, 2023 01:52
Copy link
Contributor

@swaroopar swaroopar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swaroopar swaroopar merged commit 4f6dd1e into eclipse-xpanse:main Dec 12, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ISV catalog refresh must bring control back to previously selected service
2 participants