feat(nodes): pass the library path in the context #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #246. As explained in #246, providing the path of the library that Zenoh-Flow loads is a requirement for developing extensions. For instance, in Python, the `pyo3` library needs to load the script. This change adds the accessor method `library_path` to the `Context` structure, that returns a reference to the full path of the library being loaded. * zenoh-flow-nodes/src/context.rs: - add the library_path field to the Context structure, - update the constructor accordingly, - add the accessor method `library_path()`. * zenoh-flow-runtime/src/loader/mod.rs: - update the Loader structure to also store the path of the library that is being loaded, - update the code to account for the path of the library being also stored. * zenoh-flow-runtime/src/runtime/load.rs: - remove the `Context` in the arguments of the `try_load_*` methods as it cannot be created at that stage but only when the nodes are loaded, - create the `Context` where appropriate. Signed-off-by: Julien Loudet <[email protected]>
The previous code was exposing the path of the rust library associated
with the extension, not the path of the library that was "loaded".
This code will load the rust library but keep track and expose the path
of the library that is to load (be it an extension or not).
* zenoh-flow-runtime/src/loader/mod.rs:
- differentiate the rust library from the "library to load", that, in
the case of extensions, are different,
- keep in the hashmap the "library to load" as key.
Signed-off-by: Julien Loudet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #246.
As explained in #246, providing the path of the library that Zenoh-Flow loads is a requirement for developing extensions. For instance, in Python, the
pyo3library needs to load the script.This change adds the accessor method
library_pathto theContextstructure, that returns a reference to the full path of the library being loaded.library_path().Contextin the arguments of thetry_load_*methods as it cannot be created at that stage but only when the nodes are loaded,Contextwhere appropriate.