Skip to content

Commit d2118bc

Browse files
committed
fix: infinite wait in build-check workflow
1 parent a0e3696 commit d2118bc

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

.github/workflows/build-check.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -35,20 +35,20 @@ jobs:
3535

3636
- name: Run docker image
3737
run: docker run --name zenoh_router --init --net host -d eclipse/zenoh:master
38-
continue-on-error: true
3938

4039
- name: Build project
4140
run: |
4241
make all
4342
python3 ./build/tests/modularity.py --pub $Z_FEATURE_PUBLICATION --sub $Z_FEATURE_SUBSCRIPTION --queryable $Z_FEATURE_QUERYABLE --query $Z_FEATURE_QUERY
44-
continue-on-error: true
43+
timeout-minutes: 5
4544
env:
4645
Z_FEATURE_PUBLICATION: ${{ matrix.feature_publication }}
4746
Z_FEATURE_SUBSCRIPTION: ${{ matrix.feature_subscription }}
4847
Z_FEATURE_QUERYABLE: ${{ matrix.feature_queryable }}
4948
Z_FEATURE_QUERY: ${{ matrix.feature_query }}
5049

5150
- name: Stop docker image
51+
if: always()
5252
run: |
5353
docker stop zenoh_router
5454
docker rm zenoh_router

tests/modularity.py

+1
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@ def pub_and_sub(args):
7575
# Send "q" command to z_sub to stop it
7676
z_sub_process.stdin.write("q\n")
7777
z_sub_process.stdin.flush()
78+
time.sleep(1)
7879

7980
# Wait for z_sub to finish
8081
z_sub_process.wait()

0 commit comments

Comments
 (0)