Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align z_time and z_clock primitives for Windows with Rust implementation #272

Closed
cguimaraes opened this issue Oct 26, 2023 · 1 comment
Closed

Align z_time and z_clock primitives for Windows with Rust implementation #272

cguimaraes opened this issue Oct 26, 2023 · 1 comment
Labels
enhancement Things could work better

Comments

@cguimaraes
Copy link
Member

Describe the feature

Is your feature request related to a problem?
No

Describe the solution you'd like
Currently on Windows, z_time and z_clock primitives are implemented in the same way. However, they have different purposes in mind, as mentioned in #270 .

Additional context
From @Mallets in #269:

For Windows, in Rust they base the clock implementation on QueryPerformanceCounter. We might think about updating the Windows port to that but I'd leave it as a new PR.
@cguimaraes cguimaraes added the enhancement Things could work better label Oct 26, 2023
@jean-roland jean-roland mentioned this issue Jan 4, 2024
Merged
@Mallets
Copy link
Member

Mallets commented Jan 9, 2024

Closed by #310

@Mallets Mallets closed this as completed Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Things could work better
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cguimaraes @Mallets