Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unecessary operations in kb-importer #537

Draft
wants to merge 85 commits into
base: master
Choose a base branch
from

Conversation

pedrogalvao
Copy link

Avoid uploading the affected libraries and construct changes when they are already present in the backend.
Delete affected libraries and constructs changes before uploading if the overwrite option is used,

TODOs

  • Tests
  • Documentation

Copy link
Contributor

@henrikplate henrikplate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pedrogalvao You accidentally committed java-files.txt and non-compliant-files.txt, please remove them.

@henrikplate henrikplate added the wip Work in progress - Don't merge label Apr 6, 2022
Copy link
Contributor

@henrikplate henrikplate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment on ImportVulnerability.java

kb-importer/pom.xml Outdated Show resolved Hide resolved
@henrikplate henrikplate marked this pull request as draft September 19, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wip Work in progress - Don't merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants