Support signing and verification using ECDSA #2280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpetrov
force-pushed
the
pr-subtle-sign
branch
from
380af3d to
ef30539
Compare
tbuschto
approved these changes
Dec 4, 2023
cpetrov
force-pushed
the
pr-subtle-sign
branch
from
ef30539 to
e04f112
Compare
Introduce the methods `crypto.subtle.sign()` and `crypto.subtle.verify()` to create and verify ECDSA signatures. Currently, only the combination of the algorithm `ECDSAinDERFormat` and `SHA-256` hash is supported. The algorithm `ECDSAinDERFormat` is similar to the `ECDSA` algorithm used in `SubtleCrypto`, with the distinction that signature is encoded in the DER format, diverging from the IEEE-P1363 format used in `SubtleCrypto`.
cpetrov
force-pushed
the
pr-subtle-sign
branch
from
e04f112 to
18aa66b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce the methods
crypto.subtle.sign()andcrypto.subtle.verify()to create and verify ECDSA signatures.Currently, only the combination of the algorithm
ECDSAinDERFormatandSHA-256hash is supported.The algorithm
ECDSAinDERFormatis similar to theECDSAalgorithmused in
SubtleCrypto, with the distinction that signature is encodedin the DER format, diverging from the IEEE-P1363 format used in
SubtleCrypto.