[2685] Plot training for LSF - #2695
Open
pierluigicosi wants to merge 2 commits into
Open
Conversation
clessig
reviewed
Jul 28, 2026
clessig
left a comment
Collaborator
There was a problem hiding this comment.
I cannot test so will just approve. But can we move this new code to a separate function It wasn't before but should have been. Good opportunity to clean up.
Collaborator
And please lint and link to the GitHub issue. |
pierluigicosi
force-pushed
the
pierluigicosi/dev/2685_plot_train
branch
from
September 1, 2026 09:33
51da3f4 to
93f6e59
Compare
pierluigicosi
marked this pull request as ready for review
September 1, 2026 09:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for LSF alongside Slurm when checking active job runs.
Added the LSF command to check active runs
Added a check to detect whether the scheduler is Slurm or LSF, so the correct command is used automatically
Issue Number
closes #2685
Is this PR a draft? Mark it as draft.
Checklist before asking for review
./scripts/actions.sh lint./scripts/actions.sh unit-test./scripts/actions.sh integration-testlaunch-slurm.py --time 60