feat: add strftimedelta pattern#606
Merged
sandorkertesz merged 4 commits intoecmwf:developfrom Feb 12, 2025
Merged
Conversation
Collaborator
|
@chebertpinard, I added a test for Pattern: tests/utils/test_patterns.py Can I ask you to merge the latests develop into your PR and add at least one test to it for your new feature? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #606 +/- ##
========================================
Coverage 90.29% 90.29%
========================================
Files 154 154
Lines 11572 11572
Branches 546 546
========================================
Hits 10449 10449
Misses 953 953
Partials 170 170 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggestion for a new pattern type to support passing a date with a timedelta. The syntax would look as the following.
Would allow an easier selection of data at validity time in forecast files.