Skip to content

fix tests#177

Closed
mcocdawc wants to merge 1 commit intodevelopfrom
fix_tests
Closed

fix tests#177
mcocdawc wants to merge 1 commit intodevelopfrom
fix_tests

Conversation

@mcocdawc
Copy link
Contributor

Description

Add the mpl references for tests and remove the directory from the .gitignore.

The only remaining failing tests are:

FAILED tests/images/test_healpix.py::test_healpix_interpolated - ImportError: Regridding not available. Please install the earthkit-regrid package.
FAILED tests/images/test_healpix.py::test_healpix_pixels - ImportError: The healpix plotting backend requires the healpy package.
FAILED tests/images/test_octahedral.py::test_octahedral_interpolated - ImportError: Regridding not available. Please install the earthkit-regrid package.

As the earthkit-regrid package is deprecated AFAIK, I don't know if the 1st and 3rd test should be fixed or simply removed.
Re the 2nd test. Either healpy should be added as a strict dependency, or the test should only be executed if healpy is installed. That's a call one of the maintainers has to make.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@mcocdawc mcocdawc requested a review from Copilot March 17, 2026 12:08
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mcocdawc mcocdawc mentioned this pull request Mar 17, 2026
1 task
@mcocdawc mcocdawc requested a review from Copilot March 17, 2026 12:29
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mcocdawc mcocdawc requested a review from JamesVarndell March 17, 2026 12:36
@mcocdawc
Copy link
Contributor Author

now included in #176

@mcocdawc mcocdawc closed this Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants