Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #15 +/- ##
============================================
+ Coverage 61.33% 99.57% +38.23%
============================================
Files 24 11 -13
Lines 1239 467 -772
============================================
- Hits 760 465 -295
+ Misses 479 2 -477 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR aims to make the test suite pass when running against a non-editable installation (pip install . followed by pytest), by adjusting import behavior and pytest collection settings.
Changes:
- Switched some intra-package imports from relative to absolute
earthkit.time.*imports. - Updated pytest configuration to only collect tests from
tests/(no longer fromsrc/). - Disabled
--doctest-modulesin the default pytest options.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/earthkit/time/sequence.py |
Changes calendar import to an absolute earthkit.time.* import. |
src/earthkit/time/climatology.py |
Changes imports of sequence/utilities to absolute earthkit.time.* imports. |
pyproject.toml |
Alters pytest collection (removes src from testpaths) and disables doctest execution. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| testpaths = [ | ||
| "src", | ||
| "tests", | ||
| ] |
| from typing import Container, Dict, Iterable, Iterator, Optional, Tuple, Type, Union | ||
|
|
||
| from .calendar import ( | ||
| from earthkit.time.calendar import ( |
Comment on lines
+7
to
+8
| from earthkit.time.sequence import Sequence, YearlySequence | ||
| from earthkit.time.utilities import merge_sorted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the testsuite.
Before it failed when doing
only an editable install, i.e.
worked.
Contributor Declaration
By opening this pull request, I affirm the following: