Skip to content

[fluent] fix: Use method: sel for qube expansion#178

Open
HCookie wants to merge 1 commit intodevelopfrom
fix/expand-as-qube-with-sel
Open

[fluent] fix: Use method: sel for qube expansion#178
HCookie wants to merge 1 commit intodevelopfrom
fix/expand-as-qube-with-sel

Conversation

@HCookie
Copy link
Copy Markdown
Member

@HCookie HCookie commented Mar 26, 2026

Description

Use method: sel for qube expansion

  • Due to backend take issues on fieldlists

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

- Due to backend take issues on fieldlists
@HCookie HCookie self-assigned this Mar 26, 2026
@jinmannwong
Copy link
Copy Markdown
Collaborator

Is there a problem with the take method, or is it because what you pass as internal_dims in the expand call doesn't correspond to indices?

@HCookie
Copy link
Copy Markdown
Member Author

HCookie commented Mar 26, 2026

@jinmannwong no issue with the take, but by default it was the slice and I’m not using indices, so it failed on the dim check in take.
so the later?

@jinmannwong
Copy link
Copy Markdown
Collaborator

Cool, I just wanted to check whether there was a bug or not!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants