Conversation
…geId, JobId, ComponentId Converts all SomeType = str/int type aliases in src/cascade to typing.NewType, preventing arbitrary string/int usage where a specific type is expected. Adds casts and wrapping calls at all creation sites in source files, tests, and integration_tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for TaskId, HostId, StorageId, JobId, ComponentId
Converts all SomeType = str/int type aliases in src/cascade to typing.NewType, preventing arbitrary string/int usage where a specific type is expected. Adds casts and wrapping calls at all creation sites in source files, tests, and integration_tests.
cc @jinmannwong @HCookie -- this may force to you to
castat times when interacting with low level cascade (eg when picking a DatasetId), but ultimately this should make much safer codea pity I've learned about it only today, it should have been in the codebase from day 0 :) . If for some reason it would prove too strict or annoying, we can always revert (agentically) -- I consider it an experiment at this moment