Skip to content

Add DataHandle::from_writer wrapping Rust Write sinks - #375

Merged
simondsmart merged 2 commits into
developfrom
feature/datahandle-from-writer
Oct 15, 2026
Merged

simondsmart merged 2 commits into
developfrom
feature/datahandle-from-writer

Conversation

@Choochmeque

@Choochmeque Choochmeque commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Description

Wraps any Rust std::io::Write sink (socket, compressor, …) as an eckit::DataHandle, mirroring the existing from_reader adapter: C++ forwards each write() chunk to the sink via callbacks, errors and panics surface as WriteError. Write-only, non-seekable.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

🌦️ >> Documentation << 🌦️
https://sites.ecmwf.int/docs/dev-section/eckit/pull-requests/PR-375

@Choochmeque
Choochmeque force-pushed the feature/datahandle-from-writer branch from 77f4b3c to 730c69a Compare October 8, 2026 15:57
@Choochmeque
Choochmeque marked this pull request as ready for review October 8, 2026 17:17
@codecov-commenter

codecov-commenter commented Oct 8, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.58%. Comparing base (ce25fa6) to head (cf3acc6).
⚠️ Report is 22 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #375      +/-   ##
===========================================
- Coverage    70.59%   70.58%   -0.02%     
===========================================
  Files         1207     1207              
  Lines        66076    66076              
  Branches      5065     5065              
===========================================
- Hits         46649    46639      -10     
- Misses       19427    19437      +10     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Choochmeque
Choochmeque force-pushed the feature/datahandle-from-writer branch 2 times, most recently from cf3acc6 to a4bb0aa Compare October 14, 2026 15:23
@Choochmeque
Choochmeque force-pushed the feature/datahandle-from-writer branch from a4bb0aa to a9cdaf9 Compare October 14, 2026 15:26
@simondsmart
simondsmart merged commit 55d419e into develop Oct 15, 2026
10 checks passed
@simondsmart
simondsmart deleted the feature/datahandle-from-writer branch October 15, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants