Improve null handling in package version parsing

ecoAPM · Feb 28, 2024 · ad25039 · ad25039
1 parent 8086842
commit ad25039
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/LibYear.Core/PackageVersion.cs b/src/LibYear.Core/PackageVersion.cs
@@ -15,7 +15,7 @@ public PackageVersion(string version)
 		}
 	}
 
-	public PackageVersion(NuGetVersion? version)
+	public PackageVersion(NuGetVersion version)
 		: base(version)
 	{
 	}
@@ -40,9 +40,9 @@ public override string ToString()
 			? ToString("N", VersionFormatter.Instance)
 			: OriginalVersion;
 
-	public override string ToString(string format, IFormatProvider? formatProvider)
+	public override string ToString(string? format, IFormatProvider? formatProvider)
 	{
-		if (formatProvider == null || !TryFormatter(format, formatProvider, out var formattedString))
+		if (format == null || formatProvider == null || !TryFormatter(format, formatProvider, out var formattedString))
 		{
 			formattedString = ToString();
 		}