Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECO-2666] Update arena README publish, PnL sections #509

Merged
merged 6 commits into from
Jan 18, 2025
Merged

[ECO-2666] Update arena README publish, PnL sections #509

merged 6 commits into from
Jan 18, 2025

Conversation

alnoki
Copy link
Member

@alnoki alnoki commented Jan 16, 2025 •
edited
Loading

Description

Update emojicoin arena README:

  1. Remove PnL pseudo code now that it is covered in ongoing indexing
  2. Add section with publish commands, filing [Bug][CLI] Publish simulator is broken aptos-labs/aptos-core#15769

Testing

  1. Published on testnet: https://explorer.aptoslabs.com/txn/6596176228?network=testnet

@vercel Vercel
Copy link

vercel bot commented Jan 16, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
emojicoin-dot-fun ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 9:53pm
emojicoin-dot-fun-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 9:53pm

@alnoki alnoki changed the title [ECO-2666] Refactor arena README to add publish, remove Pnl psuedo code [ECO-2666] Update arena README publish, PnL sections Jan 16, 2025
@alnoki alnoki requested review from CRBl69 and xbtmatt January 16, 2025 20:45
xbtmatt
xbtmatt approved these changes Jan 17, 2025
View reviewed changes
src/move/emojicoin_arena/README.md Outdated Show resolved Hide resolved
@alnoki alnoki requested a review from xbtmatt January 17, 2025 21:45
@alnoki alnoki enabled auto-merge (squash) January 17, 2025 21:50
@alnoki alnoki merged commit 21beff6 into main Jan 18, 2025
7 checks passed
@alnoki alnoki deleted the ECO-2666 branch January 18, 2025 01:29
xbtmatt pushed a commit that referenced this pull request Jan 24, 2025
@alnoki @xbtmatt
[ECO-2666] Update arena README publish, PnL sections (#509)
29d6693
This was referenced Jan 24, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CRBl69 CRBl69 Awaiting requested review from CRBl69

@xbtmatt xbtmatt Awaiting requested review from xbtmatt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alnoki @xbtmatt