refactor(task-registry): replace sponsors Vec with per-address persis… - #14
Merged
cybermax4200 merged 1 commit intoJul 13, 2026
Merged
Conversation
devOgazi
force-pushed
the
refactor/sponsor-set-storage
branch
from
July 13, 2026 12:11
cb27e06 to
56af28a
Compare
…tent storage Replace the O(n) linear-scan sponsor list (Vec<Address> under DataKey::Sponsors) with a Set-style pattern using per-address boolean flags (DataKey::Sponsor(Address)). - add_sponsor: set(Sponsor(addr), true) instead of Vec push + rewrite - remove_sponsor: remove(Sponsor(addr)) instead of filter-clone entire Vec - is_sponsor: has(Sponsor(addr)) instead of Vec::contains scan - Switched from instance() to persistent() storage for sponsor durability - Added **/test_snapshots/ to .gitignore to prevent merge conflicts
devOgazi
force-pushed
the
refactor/sponsor-set-storage
branch
from
July 13, 2026 12:14
56af28a to
9cc09d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the O(n) linear-scan sponsor list (
Vec<Address>underDataKey::Sponsors) with a Set-style pattern using per-address boolean flags (DataKey::Sponsor(Address)).Changes
set(Sponsor(addr), true)instead of Vec push + rewrite entire vectorremove(Sponsor(addr))instead of filter-cloning the entire Vechas(Sponsor(addr))instead ofVec::containslinear scaninstance()topersistent()storage so sponsor status survives the instance TTL (~100 ledgers), matching durability of tasks and completionsPerformance Impact
Testing
All 38 tests pass (18 task-registry + 20 reward-engine). Test snapshots updated to reflect new storage layout.
Closes #4