fix(ci): align wasm target to wasm32v1-none across deploy, docs, and CI - #17
Merged
cybermax4200 merged 1 commit intoJul 13, 2026
Merged
Conversation
Fixes ecotask-network#6. Deploy scripts and README/CONTRIBUTING docs referenced the legacy wasm32-unknown-unknown target while CI and Makefile already used wasm32v1-none. Aligns all files to wasm32v1-none and adds a contributor note explaining the difference between the two targets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6
Problem
CI and Makefile built with
wasm32v1-none, butdeploy.sh,README.md, andCONTRIBUTING.mdreferenced the legacywasm32-unknown-unknowntarget. This meant CI artifacts couldn't be used by deploy scripts, and local builds following the README would use a different target than CI.Changes
wasm32v1-nonewasm32v1-none(Soroban SDK v20+) andwasm32-unknown-unknown(legacy)Target choice rationale
wasm32v1-noneis the recommended target for Soroban SDK v20+. It produces smaller WASM binaries with lower deployment costs. CI and the Makefile were already correct; docs and deploy scripts needed alignment.