fix(reward-engine): prevent disputing Approved/Disputed verifications - #18
Merged
cybermax4200 merged 1 commit intoJul 13, 2026
Conversation
Add status guard to dispute_proof so only Pending or Rejected verifications can be disputed. Prevents retroactive minting by re-opening already Approved verifications. Closes ecotask-network#7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7
dispute_proof previously accepted any existing verification regardless of status, allowing an admin to re-open an Approved verification as Disputed — enabling retroactive minting via resolve_dispute.
Changes:
Tests added: