-
Notifications
You must be signed in to change notification settings - Fork 0
Setup action #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup action #7
Conversation
|
Nathalie, thanks for this. The difference between the
|
|
Specifying the container in the called file (in a composite action) is not directly possible (I think). If I'm right, we can change this file using something that would look like: (etc). Ugly to my tastes but we may try this if you prefer. |
|
Well, no, forget this: That won't work because I don't see, using this setting, how to split the different checks to produce several outputs as in the original version. I'll search a bit but I'm not sure there is a better solution than specifying the container in the users' files. |
|
OK, nevermind. It's easy enough to change the workflow in the cran-task-views directories. And just out of curiosity: What does the |
|
I must remove it (or at least try). It just sets a few environment variables. I don't think we need it and I thought I had already removed it (I wanted to... I must have forgotten). I'll take care of this in a couple of minutes or hours. |
|
|
|
Author added in commit 86f9112 |
|
@zeileis : For me, the lost option is not very important so we can proceed with the rest. I'll push the necessary changes in a distinct branch of CTV and will let you merge it. When it's done, I'll take care of MissingData (so you only have four pull requests to make ;-)). |
|
Great, thanks. Regarding the number of repositories: I counted on you making the changes in MissingData and Omics. And then I will take care of the other five 😅 |
|
OK, I've merged the action in the
|
This has been tested in MissingData and it works. However, this involves asking people using validate-ctv to propagate this commit:
d37e0dc
in their repository. In clear: if we directly push the current action in CTV, that will result in errors for all people currently using ctv-validate. So next steps will be:
Unsolved questions: @zeileis ?