v2.1.3: unicode-safe AI model I/O, site link, video tutorial#186
Merged
Conversation
All AI alpha-hint methods (GVM Auto, BiRefNet variants, Dynamic Matting, VideoMaMa) failed for users whose Windows username contains non-ASCII characters. The #167 facade fix covered backend/ and ui/ only; the vendored model modules kept raw cv2 file calls, which use a narrow ANSI file API on Windows and silently fail on such paths. Extraction and chroma key already used the facade, which is why only the AI paths broke. ☼ Route raw cv2.imread/imwrite/VideoCapture in gvm_core, BiRefNetModule, MatAnyone2Module, and VideoMaMaInferenceModule through backend.frame_io ☼ Add open_video_writer facade: plain writer, then parent-dir 8.3 alias, then ASCII temp staging moved into place on release() ☼ Extend the AST guard to scan all model module directories ☼ Add non-ASCII regression tests: GVM ImageSequenceReader, MatAnyone2 frame reader, and video writer round-trips across scripts
☼ Add a Website badge to the main README and all 16 translations, next to the EZSCAPE badge, linking https://ezcorridorkey.com ☼ Add an "Official site" line under the intro so the repo points its authority at the domain
☼ Add the creator's step-by-step YouTube tutorial at the top of the Installation section as a clickable thumbnail ☼ Localized caption in the main README and all 16 translations
☼ check_ffmpeg.py still loaded the pre-refactor backend/ffmpeg_tools.py single file; point it at the ffmpeg_tools/discovery.py submodule (stdlib-only, still loads standalone), unbreaking the FFmpeg verification step in 1-install for every platform ☼ 3-update.sh: repair a main branch that has no upstream before pulling, instead of aborting with 'no tracking information' ☼ Skip the MatAnyone2 unicode test when omegaconf is absent (CI installs test deps only, not the model stack)
☼ Shallow PR checkouts sever ancestry between the merge ref and origin/main, so the updater's git pull aborted with 'divergent branches'; fetch-depth 0 restores the ancestry ☼ Stop swallowing set-upstream errors in the branch setup step
☼ 3-update.bat: repair a main branch with no upstream before pulling, matching the Unix updater; a bare git pull otherwise aborts with 'no tracking information' ☼ 1-install.bat: drop the origin/master fallback when linking an install to git; origin/master froze at v1.5.2 and the fallback could silently link a fresh install to code 400+ commits behind
☼ %errorlevel% inside the parenthesized block expanded at parse time, so a failed git pull always printed '[OK] Code updated via git' and the script exited 0; use delayed expansion ☼ Match the Unix updater: keep running the dependency and weights steps, then report 'Update INCOMPLETE' and exit 1 when the pull failed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #184.
Fix: AI methods fail on non-ASCII Windows paths (#184)
All AI alpha-hint methods (GVM Auto, BiRefNet variants, Dynamic Matting, VideoMaMa) failed for users whose Windows username contains non-ASCII characters. The #167 facade fix covered backend/ and ui/ only; the vendored model modules kept raw cv2 file calls, which use a narrow ANSI file API on Windows and silently fail on such paths. Extraction and chroma key already used the facade, which is why only the AI paths broke for the reporter.
☼ Route all raw cv2.imread/imwrite/VideoCapture in gvm_core, BiRefNetModule, MatAnyone2Module, and VideoMaMaInferenceModule through the backend.frame_io facade
☼ Add an open_video_writer facade: plain writer, then parent-dir 8.3 short-path alias, then ASCII temp staging moved into place on release()
☼ Extend the AST guard test to scan all model module directories so this cannot regress
☼ Add non-ASCII regression tests: GVM ImageSequenceReader, MatAnyone2 frame reader, and video writer round-trips across accented Latin, Cyrillic, and CJK paths
Verified: raw cv2.imread returns None on an existing EXR under an accented directory while the facade reads it; full suite 723 passed.
Docs
☼ Website badge and official-site line pointing at https://ezcorridorkey.com (main README + all 16 translations), supersedes #185
☼ Creator's step-by-step YouTube tutorial linked at the top of the Installation section as a clickable thumbnail, with localized captions in all 16 translations