Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/libre and ultra testnet create account 1200 #1230

Merged
merged 8 commits into from
Jul 11, 2023

Conversation

Torresmorah
Copy link
Collaborator

Fix create account in faucet page

What does this PR do?

  • Resolve Libre testnet faucet error #1200
  • Resolve Invalid error when creating an account #1224
  • To avoid the server error wait a second after creating the account to search for the public key through the /v1/chain/get_accounts_by_authorizers
  • Don't include name in the query when is ultra testnet to resolve input.name is not allowed to be empty
  • Add visual feedback when the account name is invalid

Steps to test

  1. Run the project locally
  2. Go to faucet page
  3. Try to create an account

imagen

@Torresmorah Torresmorah self-assigned this Jul 6, 2023
} = await axiosUtil.instance.post(
`${eosConfig.apiEndpoint}/v1/chain/get_account`,
`${eosConfig.apiEndpoint}/v1/chain/get_accounts_by_authorizers`,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this required?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the action newnonebact to create the account in ultra testnet doesn't receive the account name

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this endpoint is not related to newnonebact, it is in the api node section which is different from the system contracts.

@xavier506 xavier506 merged commit aad41ed into dev Jul 11, 2023
@xavier506 xavier506 deleted the fix/libre-and-ultra-testnet-create-account-1200 branch July 11, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid error when creating an account Libre testnet faucet error
4 participants