Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/historic transactions error 1279 #1280

Merged
merged 4 commits into from
Sep 5, 2023
Merged

Fix/historic transactions error 1279 #1280

merged 4 commits into from
Sep 5, 2023

Conversation

Torresmorah
Copy link
Collaborator

@Torresmorah Torresmorah commented Sep 4, 2023 •
edited
Loading

Fix historic transactions error

What does this PR do?

  • Resolve Historic Transactions Error #1279
  • Use the sum of txs insead of the average
  • Remove the avg per block and per second
  • Use a gap of 30 minutes in the evm transactions query

Steps to test

  1. Run the project locally with the history enable
  2. Go to main page
  3. Select a range
  4. Check the data

Screenshots

Block History

imagen

@Torresmorah Torresmorah added the bug Something isn't working label Sep 4, 2023
@Torresmorah Torresmorah self-assigned this Sep 4, 2023
xavier506
xavier506 approved these changes Sep 5, 2023
View reviewed changes
Copy link
Collaborator

@xavier506 xavier506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xavier506 xavier506 merged commit 29adf7c into dev Sep 5, 2023
4 checks passed
@xavier506 xavier506 deleted the fix/historic-transactions-error-1279 branch September 5, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xavier506 xavier506 xavier506 approved these changes

Assignees

@Torresmorah Torresmorah

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Historic Transactions Error
2 participants
@Torresmorah @xavier506