Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/syncing old blocks 1385 #1386

Merged
merged 4 commits into from
Nov 11, 2023
Merged

Fix/syncing old blocks 1385 #1386

merged 4 commits into from
Nov 11, 2023

Conversation

Torresmorah
Copy link
Collaborator

Use the first inserted block to check when synchronization should stop.

What does this PR do?

  • Resolve The synchronization of old blocks ends before completion #1385
  • Persist the first inserted block to
    • Make the comparision with the next block instead of check if it is already in the DB
    • The first block could be deleted by the service to remove old blocks
  • Limit the query to get the last block in the DB
  • Use an array of promises to synchronize old blocks

Steps to test

  1. Run the project locally with EVM configuration
  2. Check the service to synchronize old blocks

Copy link
Collaborator

@xavier506 xavier506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xavier506 xavier506 merged commit 83febfe into dev Nov 11, 2023
4 checks passed
@xavier506 xavier506 deleted the fix/syncing-old-blocks-1385 branch November 11, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The synchronization of old blocks ends before completion
3 participants