Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/ricardian contract link 1378 #1401

Merged
merged 9 commits into from
Dec 11, 2023
Merged

Fix/ricardian contract link 1378 #1401

merged 9 commits into from
Dec 11, 2023

Conversation

Torresmorah
Copy link
Collaborator

@Torresmorah Torresmorah commented Dec 11, 2023 •
edited
Loading

Fix ricardian contract link and add libre node types

What does this PR do?

Steps to test

  1. Run the project locally
  2. Go to Ricardian contract page
  3. Check the links are correct
  4. Go to bp.json generator page
  5. Check the styles and new types for libre

Screenshots

Ricardian contract page

imagen
imagen

Generator page

imagen
imagen

Nodes page

imagen

@Torresmorah Torresmorah self-assigned this Dec 11, 2023
xavier506
xavier506 approved these changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@xavier506 xavier506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xavier506 xavier506 merged commit 99933f4 into dev Dec 11, 2023
4 checks passed
@xavier506 xavier506 deleted the fix/ricardian-contract-link-1378 branch December 11, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xavier506 xavier506 xavier506 approved these changes

Assignees

@Torresmorah Torresmorah

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Torresmorah @xavier506