feat(webapp): display fio address instead of owner value #1421
Conversation
![hoji-ai[bot]](https://avatars.githubusercontent.com/in/358158?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary
- Updated link text in
CountryMap.jsto displayfio_addressif available. - Truncated producer names in
ProducersChart/index.jsto 12 characters. - Updated GraphQL queries in
producer.gql.jsto includefio_address. - Modified
useEndpointsState.jsto prioritizefio_address. - Updated
ProfileCard.jsto displayfio_addressif media name is available.
Review
Overall, the changes introduce the usage of fio_address where applicable, enhancing display information for producers. However, there are potential security issues with XSS attacks and display issues with multi-byte character truncation.
| @@ -105,7 +105,7 @@ const ClusterMap = ({ data, map, mapCode }) => { | |||
| const producer = this?.point?.producer | |||
|
|
|||
| return producer?.owner | |||
| ? `<a href=/${eosConfig.producersRoute}/${producer?.owner}>${producer?.owner}</a>` | |||
There was a problem hiding this comment.
This change is fine but it would be better to escape the fio_address and owner to prevent potential XSS attacks. Consider using a library like DOMPurify.
| @@ -105,7 +105,7 @@ const CustomBarLabel = memo( | |||
| fontFamily="Roboto, Helvetica, Arial, sans-serif;" | |||
| fontWeight={isProducing ? 'bold' : 'normal'} | |||
| > | |||
| {payload.owner} | |||
There was a problem hiding this comment.
The substring operation truncates names but doesn't account for the possibility of cutting in the middle of a multi-byte character. This could cause display issues. Consider using a proper truncation library that handles multi-byte and multi-codepoint characters.
| @@ -119,7 +119,7 @@ const ProfileCard = ({ producer }) => { | |||
| <div className={classes.profile}> | |||
| <ProducerName | |||
| name={producer?.media?.name || producer?.owner} | |||
| account={producer?.media?.name ? producer?.owner : ''} | |||
There was a problem hiding this comment.
This change is fine but it would be better to escape the fio_address and owner to prevent potential XSS attacks. Consider using a library like DOMPurify.
Use the fio_address value instead of the owner
Steps to test
Screenshot