Production Release #1424
Merged
Production Release #1424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update fio network name
feat(webapp): display fio address instead of owner value
Update Network List
Update new atributes guest perms
![hoji-ai[bot]](https://avatars.githubusercontent.com/in/358158?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary
- Updated network URL configurations in multiple workflow files.
- Added new workflow file for FIO mainnet environment.
- Modified HTML meta descriptions and updated link texts.
- Included FIO logo in NetworkSelector component.
- Adapted queries and UI components to handle FIO addresses.
- Updated yarn lock file.
Review
Reviewed changes made to workflow files, HTML meta descriptions, GraphQL queries, and frontend code, including image assets.
Some comments include concerns about the consistency and correctness of the data prioritization, image handling, and YAML job naming.
| @@ -55,7 +55,7 @@ jobs: | |||
| REACT_APP_EOS_BP_JSON_ON_CHAIN_SCOPE: 'producerjson' | |||
| REACT_APP_SYNC_TOLERANCE_INTERVAL: 180000 | |||
| REACT_APP_TOKEN_SYMBOL: 'FIO' | |||
| REACT_APP_NETWORK_URL: '[{"label":"EOS","value":"https://eos.antelope.tools","mainnet":true,"icon":"eos","order":5},{"label":"XPR Network","value":"https://xpr.antelope.tools","mainnet":true,"icon":"xpr","order":3},{"label":"WAX","value":"https://wax.antelope.tools","mainnet":true,"icon":"wax","order":4},{"label":"Telos","value":"https://telos.antelope.tools","mainnet":true,"icon":"telos","order":1},{"label":"Libre","value":"https://libre.antelope.tools","mainnet":true,"icon":"libre","order":2},{"label":"LACChain EOSIO","value":"https://lacchain.antelope.tools","mainnet":true,"icon":"lacchain","order":6},{"label":"Jungle4 Testnet","value":"https://jungle.antelope.tools","mainnet":false,"icon":"jungle","order":5},{"label":"XPR Testnet","value":"https://xpr-testnet.antelope.tools","mainnet":false,"icon":"xpr","order":3},{"label":"WAX Testnet","value":"https://wax-testnet.antelope.tools","mainnet":false,"icon":"wax","order":4},{"label":"Telos Testnet","value":"https://telos-testnet.antelope.tools","mainnet":false,"icon":"telos","order":1},{"label":"Libre Testnet","value":"https://libre-testnet.antelope.tools","mainnet":false,"icon":"libre","order":2},{"label":"Ultra Testnet","value":"https://ultra-testnet.antelope.tools","mainnet":false,"icon":"ultra","order":6}]' | |||
| REACT_APP_NETWORK_URL: '[{"label":"EOS","value":"https://eos.antelope.tools","mainnet":true,"icon":"eos","order":1},{"label":"FIO","value":"https://fio.antelope.tools","mainnet":true,"icon":"fio","order":2},{"label":"Libre","value":"https://libre.antelope.tools","mainnet":true,"icon":"libre","order":3},{"label":"Telos","value":"https://telos.antelope.tools","mainnet":true,"icon":"telos","order":4},{"label":"WAX","value":"https://wax.antelope.tools","mainnet":true,"icon":"wax","order":5},{"label":"XPR Network","value":"https://xpr.antelope.tools","mainnet":true,"icon":"xpr","order":6},{"label":"Jungle4 Testnet","value":"https://jungle.antelope.tools","mainnet":false,"icon":"jungle","order":1},{"label":"FIO Testnet","value":"https://fio-testnet.antelope.tools","mainnet":false,"icon":"fio","order":2},{"label":"Libre Testnet","value":"https://libre-testnet.antelope.tools","mainnet":false,"icon":"libre","order":3},{"label":"Telos Testnet","value":"https://telos-testnet.antelope.tools","mainnet":false,"icon":"telos","order":4},{"label":"WAX Testnet","value":"https://wax-testnet.antelope.tools","mainnet":false,"icon":"wax","order":5},{"label":"XPR Testnet","value":"https://xpr-testnet.antelope.tools","mainnet":false,"icon":"xpr","order":6}]' | |||
There was a problem hiding this comment.
Ensure the order of network URLs is consistent with your requirements, as many changes were made to the "order" properties.
| tags: | ||
| - fio-v* | ||
|
|
||
| jobs: |
There was a problem hiding this comment.
Workflow name and job name are about "FIO mainnet", but the job id indicates "create-fio-testnet-image"—consider renaming for consistency.
| REACT_APP_EOS_RATE_LINK: '' | ||
| REACT_APP_USE_REWARDS: 'true' | ||
| REACT_APP_USE_VOTES: 'true' | ||
| REACT_APP_HASURA_URL: 'https://graphql-fio.antelope.tools/v1/graphql' |
There was a problem hiding this comment.
It is advisable to handle secrets properly and use placeholders instead of directly referencing secret environment variables.
| @@ -10,7 +10,7 @@ | |||
| <meta content="#ffffff" name="theme-color"> | |||
| <meta content="Antelope + EOSIO Blockchain Network Monitor and Infrastructure Dashboard" name="title"> | |||
| <meta | |||
| content="Antelope Tools Dashboard is a network monitor featuring real-time data on block producer nodes and blockchain infrastructure for multiple Antelope and EOSIO chains." | |||
There was a problem hiding this comment.
Make sure the updated meta description accurately represents the content and goals of the page.
| @@ -48,6 +49,9 @@ const LogoSvg = ({ name }) => { | |||
| case 'libre': | |||
| return <img src={libreImg} alt="libre logo" className={classes.libreImg} /> | |||
|
|
|||
| case 'fio': | |||
There was a problem hiding this comment.
Tests should be done to check if the newly imported FIO logo image is loading correctly in different environments.
| @@ -32,7 +32,8 @@ const useEndpointsState = () => { | |||
| const inserted = [] | |||
|
|
|||
| const bpName = | |||
| producer.bp_json?.org?.candidate_name || | |||
| producer?.fio_address || | |||
| producer?.bp_json?.org?.candidate_name || | |||
There was a problem hiding this comment.
This pattern prioritizes fio_address over candidate_name and organization_name. Ensure this prioritization aligns with your expected behavior.
Update FIO Mainnet workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Production Release