Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FIO Mainnet workflow #1425

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Update FIO Mainnet workflow #1425

merged 1 commit into from
Jul 10, 2024

Conversation

xavier506
Copy link
Collaborator

Update FIO Mainnet workflow

Copy link

@hoji-ai hoji-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

  • Updated job name from create-fio-testnet-image to create-fio-mainnet-image
  • Changed namespace from fio-testnet-dashboard to fio-dashboard
  • Revised ingress hosts and HAPI EOS API network name from testnet to mainnet values

Review

Changes in this pull request update the deployment workflow YAML file to switch from the FIO testnet configuration to the mainnet configuration.

@@ -6,7 +6,7 @@ on:
- fio-v*

jobs:
create-fio-testnet-image:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The job name change from create-fio-testnet-image to create-fio-mainnet-image appears correct. Ensure all references to MAINNET are consistent and that there's no environmental mix-up between testnets and mainnets.

@@ -69,9 +69,9 @@ jobs:
build-kubernetes
env:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Namespace and host changes from testnet to mainnet are correctly updated. Validate that the NAMESPACE 'fio-dashboard' and the host 'fio.antelope.tools' are correctly configured on the mainnet settings.

@@ -80,7 +80,7 @@ jobs:
POSTGRES_DB: ${{ secrets.POSTGRES_DB }}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that HAPI_EOS_API_NETWORK_NAME and HAPI_EOS_API_ENDPOINTS accurately represent the mainnet values. Misconfiguration can lead to network connection issues.

@xavier506 xavier506 merged commit b398fdc into dev Jul 10, 2024
3 checks passed
@xavier506 xavier506 deleted the feat/update-homepage branch July 10, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant