-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/fio rewards 1416 #1426
Feat/fio rewards 1416 #1426
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
- Updated the HAPI_EOS_API_NETWORK_NAME in deploy-fio-testnet.yaml from
fio-testnet
tofio
- Added FIO rewards synchronization logic in fio.service.js
- Modified getProducers function to exclude reward calculations for certain configurations
- Integrated fio.service in various parts of the application including services/index.js and producers.worker.js.
- Updated existing methods to handle FIO specific logic
- Updated frontend filters and hooks to accommodate new reward logic for FIO network
Review
Reviewed the changes related to the fio.service.js
and its associated files, including configuration for FIO rewards synchronization. Identified a potential issue with the network name change in the deployment workflow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Estimate the rewards of the day for the FIO blockchain
What does this PR do?
fio.treasury
contract tables to get the rewards that the BP can claim before the end of the dayNote
How the row if deleted when the BP claims the rewards, if there is no row for a paid producer the previous value in the DB is used
Steps to test
Screenshots