Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hapi): validate if the last schedule time is not undefined #1428

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

Torresmorah
Copy link
Collaborator

Validate if the last schedule time is not undefined

What does this PR do?

  • When the last paid schedule time is retrieve from the blockchain an error could occur that causes that value could be undefined

@Torresmorah Torresmorah self-assigned this Jul 29, 2024
Copy link

@hoji-ai hoji-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

  • Added nullish check for scheduleTime
  • Scheduled time updates and retry intervals restructured

Review

The refactor introduces validation for scheduleTime with enhanced error handling but removes a crucial line and incorrectly scopes the time update. Makes an unnecessary change to the retry interval.

hapi/src/services/fio.service.js Show resolved Hide resolved
hapi/src/services/fio.service.js Show resolved Hide resolved
hapi/src/services/fio.service.js Show resolved Hide resolved
hapi/src/services/fio.service.js Show resolved Hide resolved
@xavier506 xavier506 merged commit d3f62ce into dev Jul 31, 2024
4 checks passed
@xavier506 xavier506 deleted the fix/check-last-schedule-time-fio-blockchain branch July 31, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants