Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update user_history field types #196

Merged
merged 2 commits into from
Oct 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion tap_jotform/streams.py
Original file line number Diff line number Diff line change
Expand Up @@ -263,17 +263,25 @@ class UserHistory(JotformStream):
allowed_values=[
"userCreation",
"userLogin",
"userLogout",
"formCreation",
"formUpdate",
"formDelete",
"formPurge",
"lastUpdate",
"passwordChanged",
"portalCreated",
"portalUpdated",
"reportCreated",
"reportUpdated",
"submissionDeleteAll",
],
),
th.Property("username", th.StringType),
th.Property("ip", th.StringType),
th.Property("server", th.StringType),
th.Property("timestamp", th.IntegerType),
th.Property("email", th.EmailType),
th.Property("email", th.StringType),
th.Property("parent", th.StringType),
th.Property("subuser", th.StringType),
).to_dict()
Expand Down
5 changes: 5 additions & 0 deletions tests/conftest.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
"""Pytest configuration for tests in this directory."""

from __future__ import annotations

pytest_plugins = ("singer_sdk.testing.pytest_plugin",)
9 changes: 2 additions & 7 deletions tests/test_core.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,10 @@

from typing import Any

from singer_sdk.testing import get_standard_tap_tests
from singer_sdk.testing import get_tap_test_class

from tap_jotform.tap import TapJotform

SAMPLE_CONFIG: dict[str, Any] = {}


def test_standard_tap_tests():
"""Run standard tap tests from the SDK."""
tests = get_standard_tap_tests(TapJotform, config=SAMPLE_CONFIG)
for test in tests:
test()
TestTapJotform = get_tap_test_class(TapJotform, config=SAMPLE_CONFIG)