Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #5 - copy scripts into final build #6

Closed
wants to merge 1 commit into from

Conversation

phip123
Copy link
Contributor

@phip123 phip123 commented Aug 28, 2020

Closing #5

@phip123 phip123 requested a review from thrau August 28, 2020 08:21
@thrau
Copy link
Member

thrau commented Aug 28, 2020

wouldn't it be better to include the scripts in the setup.py to be consistent? seems we don't actually need the sources in the container if its installed as a library. or do you need the sources for something in particular?

galileo-db/setup.py

Lines 41 to 45 in 7b3192b

entry_points={
"console_scripts": [
'galileo-experiment-recorder = galileodb.cli.recorder:main'
]
},

@phip123
Copy link
Contributor Author

phip123 commented Aug 24, 2021

Closing this because solution by @thrau is more cleaner and already in the master.

@phip123 phip123 closed this Aug 24, 2021
@phip123 phip123 deleted the fix-bug-manager-cli-script-unavailable branch August 24, 2021 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants