Skip to content

Conversation

@FelixTing
Copy link
Member

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-core-contracts/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

@FelixTing FelixTing requested a review from judehung October 14, 2025 14:38
Copy link
Member

@judehung judehung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FelixTing FelixTing requested a review from judehung October 15, 2025 06:14
@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2025

Codecov Report

❌ Patch coverage is 89.22156% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.06%. Comparing base (68c33e5) to head (d009b4c).

Files with missing lines Patch % Lines
models/resourceproperties.go 61.70% 12 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            odesa    #1022      +/-   ##
==========================================
+ Coverage   42.95%   44.06%   +1.11%     
==========================================
  Files         119      126       +7     
  Lines        7220     7387     +167     
==========================================
+ Hits         3101     3255     +154     
- Misses       3774     3781       +7     
- Partials      345      351       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…exfoundry#1004)

Add Clone func for Device, DeviceProfile, ProvisionWatcher for the sdk cache to return copied data.

Signed-off-by: Bruce Huang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants