feat(ui, dom-adapters): cross-input selection #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 100% | 0/0 |
| 🟢 | Branches | 100% | 0/0 |
| 🟢 | Functions | 100% | 0/0 |
| 🟢 | Lines | 100% | 0/0 |
Test suite run success
1 tests passing in 1 suite.
Report generated by 🧪jest coverage report action from b6d8022
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 99.65% (+0% 🔼) |
853/856 |
| 🟢 | Branches | 98.7% | 228/231 |
| 🟢 | Functions | 98.1% | 207/211 |
| 🟢 | Lines | 99.64% (+0% 🔼) |
820/823 |
Test suite run success
441 tests passing in 25 suites.
Report generated by 🧪jest coverage report action from b6d8022
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟡 | Statements | 70.97% | 22/31 |
| 🔴 | Branches | 20% | 1/5 |
| 🟡 | Functions | 75% | 6/8 |
| 🟡 | Lines | 68.97% | 20/29 |
Test suite run success
4 tests passing in 1 suite.
Report generated by 🧪jest coverage report action from b6d8022
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟡 | Statements | 67.51% | 160/237 |
| 🟢 | Branches | 80% | 60/75 |
| 🔴 | Functions | 57.14% | 20/35 |
| 🟡 | Lines | 67.52% | 158/234 |
Test suite run success
67 tests passing in 4 suites.
Report generated by 🧪jest coverage report action from b6d8022
|
⏭️ No files to mutate for |
|
⏭️ No files to mutate for |
gohabereg
reviewed
Apr 12, 2025
| public detachBlock(index: Index): void { | ||
| const block = this.getBlock(index); | ||
|
|
||
| if (block) { |
| public getBlock(index?: Index): BlockToolAdapter | undefined { | ||
| if (index === undefined) { | ||
| if (this.#currentUserCaret.index === null) { | ||
| throw new Error('[CaretManager] No index provided and no user caret index found'); |
e11sy
approved these changes
Apr 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ui:before-inputto all affected inputs. To find them, it checks current range and compare its start/end with input position.this.#blocksinstead ofthis.#inputs. Thus, we won't care about managing input indexes (with block index) on block removing/moving.