Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(service): Add Whimsical and Figma services #123

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

feature(service): Add Whimsical and Figma services #123

wants to merge 7 commits into from
+47 −6

Conversation

thooams
Copy link

@thooams thooams commented Mar 26, 2024

No description provided.

neSpecc
neSpecc reviewed Mar 26, 2024
View reviewed changes
Copy link
Contributor

@neSpecc neSpecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Please, add corresponded tests, increment a patch version and update a service-list in readme

@neSpecc
Copy link
Contributor

neSpecc commented Apr 3, 2024

@thooams hey. Are you going to update the PR?

@thooams
Copy link
Author

thooams commented Apr 3, 2024

Yes. I have to find the time to do it

@thooams thooams changed the title feataure(service): Add Whimsical and Figma services feature(service): Add Whimsical and Figma services Apr 23, 2024
@thooams
Copy link
Author

thooams commented Apr 23, 2024

Tests are written.

neSpecc
neSpecc approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@neSpecc neSpecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

increment a patch version, please

neSpecc
neSpecc reviewed Jul 1, 2024
View reviewed changes
Copy link
Contributor

@neSpecc neSpecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update a list in Readme, please

@neSpecc
Copy link
Contributor

neSpecc commented Oct 12, 2024

Please, update the branch

neSpecc
neSpecc reviewed Oct 12, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
neSpecc
neSpecc reviewed Oct 12, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
neSpecc
neSpecc reviewed Oct 12, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
src/services.ts Show resolved Hide resolved
neSpecc
neSpecc requested changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@neSpecc neSpecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, remove all changes unrelated to new services

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/services.ts Outdated Show resolved Hide resolved
src/services.ts Outdated Show resolved Hide resolved
@thooams
Copy link
Author

thooams commented Oct 18, 2024

Unexpected changes were removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neSpecc neSpecc neSpecc requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thooams @neSpecc