Conversation
This commit includes only one very basic property for intervals at the time of the commit the property successfully runs for 100 instances.
There was a problem hiding this comment.
Looks good to me! One place where there were (I think) redundant parentheses.
Also, we shouldn't merge this into master just yet; should hit develop, first, and only merge develop into master once we have something resembling a release.
Not sure if there's an easy way to update a PR to change the target branch, though...
EDIT: Just discovered that it's in fact very easy to change the merge target in a PR, and did so :) So disregard that part of this comment.
|
@ChrisEPhifer I think the integration work is boils down to changing the Arbitrary instance for Interval, just using the smart constructor you are creating (I left a TODO which should mean all that is required is un-commenting the code in the TODO). Should this be merged? Or do you want to wait. |
I think this should wait until #18 is merged, since if we don't wait it will just turn into another PR for the same work. |
This commit includes only one very basic property for intervals
at the time of the commit the property successfully runs for 100
instances.