fix: restore missing Segment analytics events in Authn MFE - #12
Merged
ssurendrannair merged 10 commits intoJul 9, 2026
Conversation
ssurendrannair
requested review from
Copilot,
nakhan-sonata-afk and
subhashree-sahu31
June 24, 2026 10:57
There was a problem hiding this comment.
Pull request overview
Restores missing client-side Segment analytics events in the Authn micro-frontend by reintroducing dropped tracking calls and ensuring events include the expected app_name value used by downstream Segment dashboards.
Changes:
- Reverts
APP_NAMEtoauthn_mfeto restore downstream analytics filtering. - Replaces direct analytics calls in
LoginPagewith tracker wrappers (addsapp_name) and restores login-success + cohesion tracking behaviors. - Adds
app_nameto Logistration toggle tracking events and fixes the CSRF token effect to run once.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/data/constants.js | Restores APP_NAME value used by Segment event properties/filters. |
| src/login/LoginPage.jsx | Restores login page + success analytics via tracker wrappers, re-adds cohesion dispatch, and cookie cleanup on success. |
| src/logistration/Logistration.jsx | Adds app_name to toggle track events and fixes CSRF token effect execution frequency. |
Comments suppressed due to low confidence (1)
src/logistration/Logistration.jsx:79
sendPageEventcalls here still omit{ app_name: APP_NAME }, while the surrounding changes aim to restore Segment events withapp_namefor downstream filtering. As-is, thelogin_and_registrationpage events emitted from institution login toggles will remain missingapp_name.
sendTrackEvent('edx.bi.institution_login_form.toggled', { category: 'user-engagement', app_name: APP_NAME });
if (typeof e === 'string') {
sendPageEvent('login_and_registration', e === '/login' ? 'login' : 'register');
} else {
sendPageEvent('login_and_registration', e.target.dataset.eventName);
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+153
to
+158
| useEffect(() => { | ||
| if (loginResult.success) { | ||
| trackLoginSuccess(); | ||
| removeCookie('ssoPipelineRedirectionDone'); | ||
| } | ||
| }, [loginResult]); |
Comment on lines
266
to
271
| <RedirectLogistration | ||
| success={loginResult.success} | ||
| redirectUrl={loginResult.redirectUrl} | ||
| finishAuthUrl={finishAuthUrl} | ||
| currectProvider={currentProvider} | ||
| /> |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
src/logistration/Logistration.jsx:79
- These sendPageEvent calls still omit the app_name options object, so the corresponding page events won’t be filterable by app_name (which this PR is restoring for other Segment events). Pass { app_name: APP_NAME } as the 3rd argument (or use createPageEventTracker) for consistency.
sendPageEvent('login_and_registration', e === '/login' ? 'login' : 'register');
} else {
sendPageEvent('login_and_registration', e.target.dataset.eventName);
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/logistration/Logistration.jsx:80
- The
sendPageEvent('login_and_registration', ...)calls inhandleInstitutionLoginare missing the{ app_name: APP_NAME }context that other page events get viacreatePageEventTracker. This means these page events won’t be attributed toauthn_mfeand can still be filtered out downstream.
if (typeof e === 'string') {
sendPageEvent('login_and_registration', e === '/login' ? 'login' : 'register');
} else {
sendPageEvent('login_and_registration', e.target.dataset.eventName);
}
nakhan-sonata-afk
approved these changes
Jun 30, 2026
nakhan-sonata-afk
left a comment
nakhan-sonata-afk
left a comment
There was a problem hiding this comment.
authn_mfe has been configured. Approved
subhashree-sahu31
requested changes
Jun 30, 2026
kramakrushna
reviewed
Jul 1, 2026
Comment on lines
266
to
+270
| <RedirectLogistration | ||
| success={loginResult.success} | ||
| redirectUrl={loginResult.redirectUrl} | ||
| finishAuthUrl={finishAuthUrl} | ||
| currectProvider={currentProvider} |
Comment on lines
763
to
+769
| it('should send page event when login page is rendered', () => { | ||
| render(reduxWrapper(<LoginPage {...props} />)); | ||
| expect(sendPageEvent).toHaveBeenCalledWith('login_and_registration', 'login'); | ||
| expect(sendPageEvent).toHaveBeenCalledWith( | ||
| 'login_and_registration', | ||
| 'login', | ||
| { app_name: 'authn_mfe' }, | ||
| ); |
Comment on lines
+153
to
+158
| useEffect(() => { | ||
| if (loginResult.success) { | ||
| trackLoginSuccess(); | ||
| removeCookie('ssoPipelineRedirectionDone'); | ||
| } | ||
| }, [loginResult]); |
ssurendrannair
deleted the
AUT-209-authn-mfe-is-not-triggering-client-side-events-consistently
branch
July 9, 2026 06:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Authn MFE stopped consistently triggering client-side Segment events since Feb 20, 2026. This was traced back to the enterprise theming PR (#6) where several analytics tracking calls were inadvertently dropped during the LoginPage.jsx refactor from Redux connect to React hooks.
This PR restores all affected events.
Changes
Events Restored
Notes