Refactor course authoring test pipeline configuration#22
Merged
Conversation
dianakhuang
approved these changes
Feb 13, 2025
This was referenced Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an incremental merge along the path to enabling Datadog synthetic tests to automatically run immediately after deployments of the course authoring MFE.
It builds on two recent, related PRs:
https://github.com/edx/edx-internal/pull/12296
#21
The functionality added by this PR pertains to configuration. Specifically, configuration as to which tests ought to be run belongs in a GoCD config repository YAML file, and not in the tubular script responsible for triggering the tests and collecting test results. This follows from the observation that we want to preserve the option to customize what tests are run, and what the timeout for those runs is, on a GoCD pipeline by pipeline basis. Each pipeline will have its own YAML file, but the tubular script will be shared across pipelines.
Testing:
Equivalent code was tested on the test-GoCD servers using edx/tubular and edx-gocd-synthetic-testing repos, under
bszabo/testing-args-from-gocdbranches.This code will be tested on the stage environment post-merge without possible harm to prod.
Testing entails:
release_tests_1_pipelinepipeline has been added to thest_1_grouppipeline group