-
-
Notifications
You must be signed in to change notification settings - Fork 0
WIP: Altered data model #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
tuurma
wants to merge
238
commits into
master
Choose a base branch
from
altered-model
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+88,045
−19,047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add places in the template for (some of) relocated elements - change form bindings for the Object section
- remove form template mspart-tmpl; no longer used - remove tei:msPart from path expressions where content was deliberately pulled (keep the rest, may need revision) - remove handling of msDesc which was explicitely pulling only specific content and then wrapping parts of it in msPart - retain the scaffolding of api:to-ms-part function but only keep div handling bits (may need further revision, but dropping this off altogether caused complete breakdown of the form)
- type of inscription and note as msContents/@Class and msContents/summary - add discussion of dating - reorder various types of bibliography as specified in the meeting - adjust handling of main and used languages (via langUsage)
- note instead of rs for decoration - simplify inscription type handling
- precise binding
- metric info represented as note - languages removed (to be extracted to a langUsage section) - paleography info represented as note - ligatures info as note
- lift out most of the sections of msPart and bind them to relevant msDesc sections - remove ui elements to navigate and add fragments - add language repeats and change language bindings to langUsage - change verification bindings to respStmt - change bibliography to sourceDesc/listBibl
- change the editor to use `seg type='citedRange'` instead - fix problem with disappearing selection
- trigger to add more repeat elements - links from sidebar navigation
- remove creation of virtual msPart elements and `textpart` division - remove addition of uuid/corresp - remove pull-style explicit retrieval of body content
- switch from virtual msPart to direct operation on text/body/divs - eliminate fx-repeat binding to virtual msPart - replace with fx-group binding explicitly to the //body - as a consequence edition text and commentary now grouped at the bottom
Both are unwanted for performance and DRY reasons
…te value; address #47
…o respective label, mapped to i18n keys but still need review
- single-step refs to make sure create-nodes doesn't duplicate outer structures - free entry as `language[@Ident='edep']` - subgrouping in fieldsets/fx-groups
…sDesc/handNote segments
… together in rows, some repeats now display multiple items in a row (flex-wrap)
This should now go red when we have a bug
… in a 'fragments' attribute of a parent.
Just temporary, until the issue with codemirror/view is resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
edit.htmlform accordinglymsParthandlingTODO: