Add a stand-alone metadata editing profile and streamline code #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrRataplan
force-pushed
the
feat/forms
branch
2 times, most recently
from
69fa292 to
de104ec
Compare
duncdrum
reviewed
Nov 25, 2025
Contributor
duncdrum
left a comment
duncdrum
left a comment
There was a problem hiding this comment.
I think this also needs a rebase. The repo.xml should not have been updated, adding some tests to the metadata profile would be great.
So it can be opened separately from jinntap. Useful for larger metadata panels
fixed/updated bindings now always using 'authority-default' as instance;
it's standalone by default now
The result of saving is some json. Not the XML instance
DrRataplan
force-pushed
the
feat/forms
branch
from
de104ec to
ce84999
Compare
wolfgangmm
reviewed
Dec 4, 2025
Member
There was a problem hiding this comment.
Some issues I found testing this PR:
- when I open a document in JinnTap (say the Leibniz), I get an error in the console when I click on the header editing icon
- the sample standalone header editing form is very basic. It would be great to at least have a repeat for the author, so users get an idea how this would look like in code.
- the styling of the save button in the standalone header editing form looks weird:
- the forms and metadata-editor profile should have a README with some documentation to help users get started on customizing the forms for their own needs.
But if you could just look into the first issue, I would go ahead and merge this PR to make it easier for us to continue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.