Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating docker commands in README. #190

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iwonagg
Copy link

@iwonagg iwonagg commented Jun 7, 2023

No description provided.

@tuurma
Copy link
Member

tuurma commented Jun 7, 2023

I'd say we should stick to straight quotes " instead of (yes, I know some were there before ;-) ). Otherwise looks good to me.

@iwonagg
Copy link
Author

iwonagg commented Jun 7, 2023

I'd say we should stick to straight quotes " instead of (yes, I know some were there before ;-) ). Otherwise looks good to me.

To tell the truth, I corrected it instinctively, to unify (there were half that way, half another). I as a philologist prefer correct quotation marks, dashes, etc in natural language text and straight quotes in commands, but of course, it is only one point of view.

@tuurma
Copy link
Member

tuurma commented Jun 7, 2023

Ha, in fact, this being markdown I think we should stick to semantics and therefore replace all these quotes either with * for emphasis, like titles, or inline code quotes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants