configure.ac: Add option to configure script for benchmarks. #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in eellak#205, this commit makes it so that building the benchmark directory is optional and disabled by default. I'd argue opt-in is superior in our case since benchmarks are only relevant to the developers of this project. This allows us to add a as many dependencies to benchmark as we possibly want or need, without minding the extra dependencies that we add to the project. We still have to face the fact that different benchmark targets have different dependencies and perhaps we'd want to provide options for each separate benchmark but I find this too complicated. Signed-off-by: Fotios Valasiadis <[email protected]>
|
Also worth noting, perhaps we'd want to add some doc about how to run benchmarks in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #205, this commit makes it so
that building the benchmark directory is optional
and disabled by default. I'd argue opt-in is superior in our case since benchmarks are only relevant to the developers of this project.
This allows us to add a as many dependencies to benchmark as we possibly want or need, without minding the extra dependencies that we add to the project.
We still have to face the fact that different benchmark targets have different dependencies and perhaps we'd want to provide options for each separate benchmark but I find this too complicated.