Skip to content
This repository has been archived by the owner on Dec 3, 2019. It is now read-only.

fixes #34 #35

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fixes #34 #35

wants to merge 2 commits into from

Conversation

shivanshuraj1333
Copy link
Contributor

This pull request fixes #34
Below is the working of populate_db.py after modification
issue#34
issue#34

@zvr
Copy link
Collaborator

zvr commented Mar 12, 2019

Thanks for this, but this introduces too many dependencies that are not specified -- and eventually limits the applicability.
And, as was stated in #34 the gain is only for the developer.

@shivanshuraj1333
Copy link
Contributor Author

I have removed all unwanted dependencies. Only one extra dependency is needed to be installed i.e. tqdr. It is to be noted that the process took 1h 53min to complete, without progress bar it is very inconvenient to proceed and I have followed general method to display progress.
If this fix is able to resolve the issue please merge or else tell me any other probable solution.

@shivanshuraj1333
Copy link
Contributor Author

@zvr please review the changes once again.
Thank you!

@zvr
Copy link
Collaborator

zvr commented Mar 26, 2019

1h 53min is completely unreasonable!

I made a single-line patch in #43 and populate now takes 12sec on my laptop...
Definitely no need for extra code for something like this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No progress bar in populate_dp.py
2 participants