Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate LEF Parser #436

Closed
wants to merge 11 commits into from
Closed

Integrate LEF Parser #436

wants to merge 11 commits into from

Conversation

donn
Copy link
Member

@donn donn commented Mar 25, 2024

Steps

  • Verilator.Lint

    • LEF views are now used as a fallback if no Verilog views are available for a Macro
  • New steps, Misc.CheckMacroAntennaProperties and Misc.CheckDesignAntennaProperties

    • Checks the existence of antenna gate and antenna diffusion area on macro and final design pins respectively without invoking OpenROAD
  • Yosys.*

    • LEF views are now used as a fallback if no Verilog views are available for a Macro

Misc.

  • openlane.common
    • Toolbox
      • New method header_from_lef that creates a Verilog header from a LEF file

Tool Updates

  • Added the Efabless ANTLR4-based lef_parser at v0.1.0

Resolves #440

@openlane-bot
Copy link
Collaborator

openlane-bot commented Mar 25, 2024

Metric comparisons are in beta. Please report bugs under the issues tab.

To create this report yourself, grab the metrics artifact from the CI run, extract them, and invoke python3 -m openlane.common.metrics compare-main <path to directory>.

  • No changes to critical metrics were detected in analyzed designs.

Full tables ► https://gist.github.com/openlane-bot/7a0a4f006c8db63c0cc30f0ab6211f09

@donn donn marked this pull request as ready for review April 2, 2024 00:55
@kareefardi
Copy link
Collaborator

kareefardi commented Apr 2, 2024

Couple of initial comments:

  • Can you add known limitations or language coverage or something similar to https://github.com/efabless/lef_parser?
  • The bot is reporting a new result but I am not seeing any new designs added in the diff.

@donn donn changed the base branch from main to dev April 24, 2024 08:55
@donn donn added this to the 2.1.0 milestone Apr 24, 2024
@donn donn marked this pull request as draft April 29, 2024 16:03
@donn donn removed this from the 2.1.0 milestone May 1, 2024
@donn
Copy link
Member Author

donn commented May 1, 2024

This PR will not be merged until the LEF parser achieves more substantial coverage of the LEF standard.

@donn donn closed this Jun 2, 2024
@donn donn deleted the integrate_lef_parser branch June 2, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing flow on step "Check Antenna Properties of Pins in The Generated Design LEF view"
3 participants