Improve typings for condition operator
#321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kireevmp
force-pushed
the
feat/condition-types
branch
from
29b7fe2 to
648af81
Compare
sergeysova
approved these changes
Jan 31, 2024
Closed
AlexandrHoroshih
approved these changes
Feb 5, 2024
sergeysova
changed the title
condition typescondition operator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #184
Closes #185 #109
This PR aims to simplify and shorten some of the overloads of
condition. This only changes types, and does not touch runtime.Booleanas a supported type guardEvent,EffectandStoreinsourceinto a single typeAll existing type tests pass. I've also added a couple of new type tests.
In future this may allow to add
clockorfntocondition, as types are more manageable now