Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Coverage & Add Tests #29

Merged
merged 8 commits into from
Aug 30, 2023
Merged

Improve Coverage & Add Tests #29

merged 8 commits into from
Aug 30, 2023

Conversation

smashedr
Copy link
Collaborator

@smashedr smashedr commented Aug 9, 2023

Drafting PR to Test

@coveralls
Copy link

coveralls commented Aug 9, 2023 •
edited
Loading

Coverage Status

coverage: 76.154% (+14.6%) from 61.538% when pulling 351bffa on smashedr:coverage into dc8f8ca on egeland:master.

@smashedr
Copy link
Collaborator Author

smashedr commented Aug 9, 2023

Would like to use pytest --cov do reduce run-time of coverage container.

But, these runs should still complete and I have no idea why the actions runs are failing, no error messages. Will look into it later, welcome to any feedback.

@smashedr smashedr marked this pull request as ready for review August 24, 2023 08:57
@smashedr smashedr changed the title Improve Coverage Improve Coverage & Add Tests Aug 24, 2023
@smashedr
Copy link
Collaborator Author

Adds unit testing.

@smashedr
Copy link
Collaborator Author

Going to smash this, it only touches testing. Thanks.

@smashedr smashedr merged commit 18aa051 into egeland:master Aug 30, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@altmas5 altmas5 altmas5 approved these changes

@egeland egeland Awaiting requested review from egeland

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smashedr @coveralls @altmas5